Skip to content

Conversation

@mbuechse
Copy link
Contributor

Closes #933

@mbuechse mbuechse requested review from fkr and garloff September 16, 2025 12:09
@mbuechse mbuechse marked this pull request as draft September 16, 2025 12:09
@chrisschwa
Copy link
Contributor

Should the image_source format always be from the osism repository or should we not be able to host our own images?

@mbuechse
Copy link
Contributor Author

Should the image_source format always be from the osism repository or should we not be able to host our own images?

This is up for debate. So far, this hasn't come up. If other people want to host the image, they can probably be added, given that the relevant bodies agree.

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment:
We've had standardized image names before. Shouldn't we keep them as a recommendation? This would reduce the chance for breakage of customer automation ...

@mbuechse mbuechse force-pushed the feat/scs-0104-v2 branch 2 times, most recently from 2991d81 to f0b72ff Compare December 1, 2025 20:12
@mbuechse mbuechse marked this pull request as ready for review December 1, 2025 20:14
Copy link
Contributor

@depressiveRobot depressiveRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the link to the new SCS website.

I focused on formalities in the review. Someone else should check again contentwise and resolve the open conversations.

@depressiveRobot
Copy link
Contributor

@garloff @fkr What's the status here? I think this "just" needs resolving open conversations and a final review contentwise and then it can be merged.

mbuechse and others added 7 commits January 22, 2026 17:19
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Co-authored-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Marvin Frommhold <depressiveRobot@users.noreply.github.com>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
@mbuechse
Copy link
Contributor Author

I think this draft(!) has seen enough scrutiny for a first merge. We still need to supply tests, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend standard images standard to move away from fixed names

6 participants