Refactor: Convert Slider to Functional Component#5
Open
sean5940 wants to merge 3 commits intofeat/integrate-fast-shadowfrom
Open
Refactor: Convert Slider to Functional Component#5sean5940 wants to merge 3 commits intofeat/integrate-fast-shadowfrom
sean5940 wants to merge 3 commits intofeat/integrate-fast-shadowfrom
Conversation
I've converted the Slider class component in `src/Slider.js` to a functional component using hooks. - State is now managed with `useState`. - Lifecycle methods (`componentWillMount`, `componentWillReceiveProps`) have been replaced with `useEffect`. - PanResponder logic has been preserved. - All class methods were converted to named functions within the component. Note: I attempted to add unit tests with `@testing-library/react-native` but was unsuccessful due to significant Jest environment and React Native version (0.43.3) compatibility issues. Further investigation and potentially a dedicated effort to modernize the testing setup would be required to add comprehensive tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've converted the Slider class component in
src/Slider.jsto a functional component using hooks.useState.componentWillMount,componentWillReceiveProps) have been replaced withuseEffect.Note: I attempted to add unit tests with
@testing-library/react-nativebut was unsuccessful due to significant Jest environment and React Native version (0.43.3) compatibility issues. Further investigation and potentially a dedicated effort to modernize the testing setup would be required to add comprehensive tests.