[Custom Storage 1/3] Add defs for custom storage main #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks Kyle! Generally LGTM, just a few small comments
mkolodner-sc
approved these changes
Jan 26, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
This LGTM! Thanks Kyle
svij-sc
approved these changes
Jan 28, 2026
Collaborator
svij-sc
left a comment
svij-sc
left a comment
There was a problem hiding this comment.
Minor comment re: documentation
| } | ||
|
|
||
| // Configuration for GraphStore storage. | ||
| message GraphStoreStorageConfig { |
Collaborator
There was a problem hiding this comment.
Is this always needed to be specified by user or do we have some sane default values here?
Let's document if so?
Collaborator
Author
There was a problem hiding this comment.
Hmmm for now we always want this to be supplied. However we can have some purely "config based" approach in the future, I've expanded these defs to accommodate that in the future if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Add proto definitions for custom storage main for graph store mode.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO