Open
Conversation
Efnilite
reviewed
Jul 18, 2025
Member
Efnilite
left a comment
There was a problem hiding this comment.
i like the new structure, good work 🙏
sovdeeth
requested changes
Dec 3, 2025
Member
sovdeeth
left a comment
There was a problem hiding this comment.
some sections look unfinished with todos or just stubs, is that intentional?
Missing a lot of documentation but otherwise seems pretty good
sovdeeth
requested changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current way the /sk command is written makes it nearly impossible to add new features, fix bugs, or even tell what's going on.
There are also lots of issues created for the /sk command that were untouched for a long time.
Solution
Deletes the old SkriptCommand and SkriptCommandTabCompleter classes and replaces them with a new SubCommand class.
To add a new SubCommand, you create a new class for your command and extend SubCommand:
Then, add your subcommand inside the new SkriptCommand class
For commands that share a lot of code, such as
/sk enable | disable | reload, a new ScriptCommandUtils class was added as a utility class.This approach makes it way easier to work on anything related to the /sk command.
Full Changelog
SkriptConfig.load()is now public (marked as internal)skript command.help.show#7606)/sk recovercommand that dumps all scripts in memory to files, useful for recovering accidentally deleted scripts.Added a new/sk parse <code>command that works the same way as effect commands do, except they don't have to be enabled through the config. (parse effect subcommand #6899)Node#getCommentandNode#getIndentationwere made public for/sk recover(marked as internal)[Skript]prefixes in/sk reload(Skript errors missing prefix in dev/feature #7297)/sk infois now more detailed:/sk reload lastfor reloading the last reloaded script. The savedlastscript is globalTODO List
I created this PR early to get initial feedback on the new structure, and so that people can recommend changes on the old command code. If you have any suggestions for new commands, drop them here.
Completes: none
Related: none