Skip to content

Custom Embed per Page + Improved Sample App #1

Open
Hamsterland wants to merge 22 commits intoShukashuu:masterfrom
Hamsterland:embed
Open

Custom Embed per Page + Improved Sample App #1
Hamsterland wants to merge 22 commits intoShukashuu:masterfrom
Hamsterland:embed

Conversation

@Hamsterland
Copy link

Definitely breaking, lots of internal changes.

Added

  • New sample app
  • Custom embed per page

Improvement

  • Proper documentation
  • Messy practices here and there

Solutions

  • Write documentation
  • Use builder methods

Working for testing but not production.

Interactive.RemoveReactionCallback(message);
_ = Message.DeleteAsync();
Interactive.RemoveReactionCallback(m1);
m2.RemoveAllReactionsAsync();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep the paginator but stop interaction.

@Shukashuu Shukashuu added the enhancement New feature or request label Jul 8, 2020
@Hamsterland
Copy link
Author

Sorry for the long delay, it should be ready for merge now. I'd recommend not merging into master and test out on another branch instead.

@Hamsterland Hamsterland marked this pull request as ready for review November 28, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants