Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
mockReturnValue() with a mockImplementation() that returns different directory contents based on which path is being read. This allows listFilesRecursively to properly traverse the nested structure and return the correct relative path templates/skeleton/app/components/Foo.tsx, which matches the ingredient path in the recipe.
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
kdaviduik
left a comment
kdaviduik
left a comment
There was a problem hiding this comment.
Aside from the --no-verify thing this LGTM!
| execSync(`git add .`, {cwd: REPO_ROOT}); | ||
| execSync( | ||
| `git commit --allow-empty -m "Merge ${applyBranch} into ${parsedReferenceBranch.branch}"`, | ||
| `git commit --no-verify --allow-empty -m "Merge ${applyBranch} into ${parsedReferenceBranch.branch}"`, |
There was a problem hiding this comment.
Why the --no-verify added to both of these? Imo we should not disable any of the pre-commit hooks
There was a problem hiding this comment.
@kdaviduik the --no-verify was missing for this specific the intermediate commit step that the update command makes.
All the other git add have a --no-verify flag added. When it tries to commit after user resolves conflicts it fails on the patches, but it shouldn't have to when it makes these temp branches and commits to them.
|
We detected some changes in |
`dirent.path` was deprecated in Node.js v20.12.0 in favor of `dirent.parentPath`, and on Node.js v24 it returns undefined. The fix is to use `parentPath` falling back to the deprecated `path` for older versions
New dependencies updated updated zod so we need to update the schema validation definition
2 participants
WHY are these changes introduced?
Closes https://github.com/Shopify/developer-tools-team/issues/986.
Closes https://github.com/Shopify/developer-tools-team/issues/1008.
The cookbook recipes were failing because patches were using an old snapshot of the skeleton template, so when the recipe is applied, it fails.
WHAT is this pull request doing?
/recipe-apply-and-fix.prompt.mdClaude command to help aid with fixing recipes by fixing recipes with latest skeleton template changesHOW to test your changes?
SHOPIFY_HYDROGEN_FLAG_LOCKFILE_CHECK=false npm run cookbook -- validateto validate all testsSHOPIFY_HYDROGEN_FLAG_LOCKFILE_CHECK=false npm run cookbook -- validate --recipe <RECIPE_NAME>to validate a specific recipeChecklist