chore: bump node and npm versions by fredericoo · Pull Request #3404 · Shopify/hydrogen

fredericoo · 2026-01-23T15:40:28Z

WHY are these changes introduced?

Node v20 will reach end of life on 30 Apr 2026

~~This PR bumps the node version to the current LTS and npm to the version that comes bundled with that given node version (https://nodejs.org/en/blog/release/v24.11.1)~~

This PR makes it so we use node v24 for development (.nvmrc, dev.yml) and node 22 for CI. We still will widely support 22, but are making a push to consumers to upgrade ahead of EOL. (context/decision)

This way we experience node 24 and can upgrade CI to 24 when ready.

WHAT is this pull request doing?

Updates Node.js version from v20 to v24.11.1 in .nvmrc
Updates npm version requirement to v11.6.2 in package.json
Updates engine requirements in package.json to specify minimum Node.js v24.11.1 and npm v11.6.2
Breaks away from nvmrc in CI tasks, hardcoding node 22 instead.

HOW to test your changes?

Install Node.js v24.11.1 (using nvm: nvm install && nvm use)
Update npm to v11.6.2 (npm install -g npm@11.6.2)
Run npm install
Verify the project builds and runs correctly with the new Node.js and npm versions
Run tests to ensure compatibility

Checklist

I've read the Contributing Guidelines
I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've added a changeset if this PR contains user-facing or noteworthy changes
I've added tests to cover my changes
I've added or updated the documentation

fredericoo · 2026-01-23T15:40:48Z

chore: bump node and npm versions #3404 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

shopify · 2026-01-23T15:42:22Z

Oxygen deployed a preview of your 01-23-chore_use_node_lts_for_monorepo branch. Details:

Storefront	Status	Preview link	Deployment details	Last update (UTC)
Skeleton (skeleton.hydrogen.shop)	✅ Successful (Logs)	Preview deployment	Inspect deployment	February 16, 2026 1:04 PM

Learn more about Hydrogen's GitHub integration.

package.json

fredericoo · 2026-01-26T14:02:58Z

package.json

 {
  "name": "hydrogen",
-  "packageManager": "npm@10.9.2",
+  "packageManager": "npm@11.6.2",


we don’t have to bump this, if you have strong feelings to keep using npm v10 im happy to revert

the more important part is that all devs use corepack enable so we don’t have lockfile conflicts between npm 10 and 11 (look at the changes in this PR, those were lockfile v11 upgrades)

It seems the lockfileVersion in package-lock didn't change so it's probably OK to bump this

github-actions · 2026-01-26T14:19:07Z

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

graygilmore · 2026-01-26T17:46:18Z

package.json

  },
  "engines": {
-    "node": ">=18.0.0"
+    "node": "^22 || ^24",


If we're going to use multiple versions we will probably want to update our CI workflows to run tests on both, too, instead of leveraging the .nvmrc https://github.com/Shopify/hydrogen/blob/main/.github/workflows/ci.yml#L19

We'd need to set up a matrix kind of like the CLI: https://github.com/Shopify/cli/blob/main/.github/workflows/tests-main.yml#L34

(or we could just roll with v22 for now)

22 only makes more practical sense (or 24 only even)

this is only the monorepo, e2e tests run against the dev app which runs on workerd so no need to run those again

unit tests already have low parity with prod, as our app runs on node/workerd at a number of versions (you can fully pass a unit test and fail to build in oxygen by using node:fs in a function)

Devs will test locally with v24, let's keep v22 covered on CI at least 🤔

yeah agreed, i’ll skip on the matrix for now (because it wont actually change the runtime, as the dev server runtime is workerd)

will adjust the version in CI

frandiox

Just a comment on CLI versioning, otherwise I think it's good to bump this for the next major release, thanks!

frandiox · 2026-01-30T00:56:54Z

packages/cli/package.json

  "engines": {
-    "node": ">=18.0.0"
+    "node": "^22 || ^24"
  },


Oof, it seems Shopify's CLI relies on Node v20. Perhaps we should add ^20 || ^22 || ^24 here as well to ensure our plugin works with the global CLI bundling?

I don't think they require v20 for "running" the CLI, but at least during the bundling process they will install our plugin and use v20 to do things 🤔

yeah the CLI is bundled by @shopify/cli and also ran locally by users

to avoid any sort of warning from the official CLI bundling, we can keep supporting 20 for it

frandiox · 2026-01-30T00:59:43Z

package.json

 {
  "name": "hydrogen",
-  "packageManager": "npm@10.9.2",
+  "packageManager": "npm@11.6.2",


It seems the lockfileVersion in package-lock didn't change so it's probably OK to bump this

kdaviduik

The node version in dev.yml also needs a bump. We have a CI check for this but this PR was put up before this was added

…lts_for_monorepo

fredericoo · 2026-02-17T12:59:44Z

Merge activity

Feb 17, 12:59 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Feb 17, 12:59 PM UTC: @fredericoo merged this pull request with Graphite.

fredericoo marked this pull request as ready for review January 23, 2026 15:49

fredericoo requested a review from a team as a code owner January 23, 2026 15:49

graygilmore reviewed Jan 23, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

fredericoo commented Jan 26, 2026

View reviewed changes

chore: use node lts for monorepo

17f2417

fredericoo force-pushed the 01-23-chore_use_node_lts_for_monorepo branch from 910913d to 17f2417 Compare January 26, 2026 14:18

graygilmore reviewed Jan 26, 2026

View reviewed changes

thomasKn mentioned this pull request Jan 27, 2026

Upgrade to Vite 7 (breaking change) #3417

Open

5 tasks

fredericoo requested a review from graygilmore January 29, 2026 11:54

fredericoo changed the title ~~chore: use node lts for monorepo~~ chore: bump node and npm versions Jan 29, 2026

graygilmore requested a review from frandiox January 30, 2026 00:25

frandiox approved these changes Jan 30, 2026

View reviewed changes

kdaviduik requested changes Jan 30, 2026

View reviewed changes

fredericoo added 7 commits February 16, 2026 12:10

chore(deps): keep node 20 for cli

3730e9b

chore(deps): dev version of node

3d050e8

ci: use node 22 for CI jobs

768b788

Merge remote-tracking branch 'origin/main' into 01-23-chore_use_node_…

3b3a3d9

…lts_for_monorepo

chore: nvmrc

69e5b8b

ci: use latest node 22

5a17927

Merge remote-tracking branch 'origin/main' into 01-23-chore_use_node_…

3ab5d38

…lts_for_monorepo

fredericoo requested a review from kdaviduik February 16, 2026 14:33

kdaviduik approved these changes Feb 16, 2026

View reviewed changes

fredericoo merged commit 1fa96e5 into main Feb 17, 2026
16 checks passed

fredericoo deleted the 01-23-chore_use_node_lts_for_monorepo branch February 17, 2026 12:59

Conversation

fredericoo commented Jan 23, 2026 • edited by kdaviduik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

HOW to test your changes?

Checklist

Uh oh!

fredericoo commented Jan 23, 2026

Uh oh!

shopify bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frandiox left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kdaviduik left a comment

Choose a reason for hiding this comment

Uh oh!

fredericoo commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fredericoo commented Jan 23, 2026 •

edited by kdaviduik

Loading

shopify bot commented Jan 23, 2026 •

edited

Loading

fredericoo commented Feb 17, 2026 •

edited

Loading