-
Notifications
You must be signed in to change notification settings - Fork 16
feature to write the name of artifact with custom and dynamic inputs #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…namic inputs Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Review FeedbackIssue 1:
|
| return template | ||
| .replace(/\{\{run_id\}\}/gi, context.runId) | ||
| .replace(/\{\{timestamp\}\}/gi, timestamp) | ||
| .replace(/\{\{dataset\}\}/gi, 'default') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This placeholder is hardcoded to always return "default". Either remove this placeholder or properly implement it by adding dataset to the execution context.
| .replace(/\{\{run_id\}\}/gi, context.runId) | ||
| .replace(/\{\{timestamp\}\}/gi, timestamp) | ||
| .replace(/\{\{dataset\}\}/gi, 'default') | ||
| .replace(/\{\{task\}\}/gi, context.componentRef) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misleading name: this returns the component reference ID (node ID in workflow), not a task name. Consider renaming to node_id or component_ref for clarity.
| * Supported placeholders: | ||
| * - {{run_id}} - Current run ID | ||
| * - {{timestamp}} - Unix timestamp in milliseconds | ||
| * - {{dataset}} - Dataset name (if available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation says "Dataset name (if available)" but this actually returns the hardcoded string "default". Please either remove this placeholder or implement it properly.
| * - {{run_id}} - Current run ID | ||
| * - {{timestamp}} - Unix timestamp in milliseconds | ||
| * - {{dataset}} - Dataset name (if available) | ||
| * - {{task}} - Task name (if available) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation says "Task name (if available)" but this actually returns the component reference ID. Please update the documentation or rename the placeholder.
|
|
||
| // Extract a shorter run name from runId (last segment after last hyphen, or first 8 chars) | ||
| const runIdParts = context.runId.split('-'); | ||
| const runName = runIdParts.length > 1 ? runIdParts.slice(-1)[0] : context.runId.slice(0, 8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is confusing and unpredictable - it takes the last segment after a hyphen, or the first 8 characters of the runId. Consider removing this placeholder or adding an actual run name to the execution context.
…namic inputs
Summary
Changes
Testing
bun run testbun run lintbun run typecheckDocumentation
docs/guide.md) or checked that no updates are needed..ailogs when applicable.