Skip to content

Conversation

@krishna9358
Copy link
Contributor

Summary

  1. Fix node positions overlapping in Execute mode
    Issue: When switching from Design to Execute mode, workflow nodes would overlap and appear in incorrect positions instead of maintaining their layout.
    Solution: Fixed stale closure issue in Canvas.tsx where fitView was using outdated node positions. Changed to use reactFlowInstance.getNodes() to get current node positions instead of relying on the stale closure.
    File: frontend/src/components/workflow/Canvas.tsx

  2. Disable Rerun button while workflow is running
    Issue: The "Rerun" button in the execution sidebar was enabled while the workflow was still running, which could cause confusion.
    Solution: Added disabled state to Rerun buttons when the run is still in progress (live/running status). Also added tooltip explaining "Wait for run to complete".
    Files:
    frontend/src/components/timeline/RunSelector.tsx
    frontend/src/components/timeline/ExecutionInspector.tsx

  3. Fix scroll behavior on workflow nodes
    Issue: When mouse is over a workflow component with scrollable content (error panel, text blocks, validation dock), scrolling with mouse wheel would zoom the canvas instead of scrolling the content.
    Solution: Added onWheel={(e) => e.stopPropagation()} to scrollable elements to prevent wheel events from bubbling up to React Flow canvas.
    Files:
    frontend/src/components/workflow/ExecutionErrorView.tsx
    frontend/src/components/ui/markdown.tsx
    frontend/src/components/workflow/ValidationDock.tsx

Testing

  • bun run test
  • bun run lint
  • bun run typecheck
  • Additional notes:

Documentation

  • Updated the relevant doc(s) (see docs/guide.md) or checked that no updates are needed.
  • Recorded contract/architecture changes in both public docs and .ai logs when applicable.

Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@krishna9358 krishna9358 changed the title @krishna9358/UI ux changes 3 Fixed the ui-ux changes. Jan 27, 2026
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Copy link
Contributor

@betterclever betterclever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All three fixes match their descriptions:

  1. ✅ Canvas stale closure fix - good detailed comment explaining the issue
  2. ✅ Rerun button disabled during live runs - works in both components
  3. ✅ Scroll stopPropagation to prevent canvas zoom

Minor note: is now duplicated between RunSelector.tsx and ExecutionInspector.tsx, but that's fine for a follow-up refactoring.

Copy link
Contributor

@betterclever betterclever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All three fixes match their descriptions. Canvas stale closure fix, Rerun button disabled during live runs, and scroll stopPropagation to prevent canvas zoom. Minor note: isRunLive is now duplicated between RunSelector.tsx and ExecutionInspector.tsx, but that's fine for a follow-up refactoring.

@betterclever betterclever merged commit 0e78cb8 into main Jan 28, 2026
3 checks passed
LuD1161 pushed a commit that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants