Skip to content

Conversation

@krishna9358
Copy link
Contributor

@krishna9358 krishna9358 commented Jan 22, 2026

Summary

  1. Currently the artifact's row doesn't help. We should display the following:
  • Workflow name .
  • Link to run from which the artifact was generated.
  • Actions should have 'Download' and 'Delete' icon. and left align 'Actions' in the column.
  • Remove the 'Copy ID' button. serves no purpose.
  • Remove the 'COMPONENT' column.
  1. Artifact Download Button Fix (Backend)
    Issue: Download buttons in the Run Artifacts Panel weren't working.

Root Cause: The backend URL path used {artifactId} but the DTO schema expected
id, causing a parameter mismatch.

Files Changed:

backend/src/storage/dto/artifacts.dto.ts

  • Added new RunArtifactIdParamSchema and RunArtifactIdParamDto
    that uses artifactId as the property name
    backend/src/workflows/workflows.controller.ts
  • Updated to use the new DTO and fixed the import to remove unused types
    frontend/src/services/api.ts
  • Changed
    downloadArtifact
    to use direct fetch with manually constructed URL (bypassing the typed client with the OpenAPI spec bug)
  1. Blank Canvas When Navigating From Artifact Library (Frontend)
    Issue: Clicking run links in the Artifact Library opened the workflow page with a blank canvas; only refreshing showed the graph.

Root Cause: When navigating directly to a run URL, the execution graph wasn't being initialized because the code was skipping initialization when there was a run context.

Files Changed:

frontend/src/features/workflow-builder/WorkflowBuilder.tsx

  • Changed logic to always initialize execution nodes when they're empty, regardless of run context
    frontend/src/features/workflow-builder/hooks/useWorkflowExecutionLifecycle.ts
  • Added safety checks to avoid hydrating from empty design state
  1. Added delete functionality to delete the artifacts.

Testing

  • bun run test
  • bun run lint
  • bun run typecheck
  • Additional notes:

Documentation

  • Updated the relevant doc(s) (see docs/guide.md) or checked that no updates are needed.
  • Recorded contract/architecture changes in both public docs and .ai logs when applicable.

Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
@krishna9358 krishna9358 force-pushed the @krishna9358/artifect-fixes branch from ed8df46 to 734c820 Compare January 23, 2026 13:23
@LuD1161 LuD1161 changed the title feat: added the artifect download button, and revamp artifect library feat: added the artifact download button, and revamp artifect library Jan 27, 2026
@LuD1161 LuD1161 changed the title feat: added the artifact download button, and revamp artifect library feat: added the artifact download button, and revamp artifact library Jan 27, 2026
@betterclever
Copy link
Contributor

Hey! When testing this PR locally, I'm hitting a React Hooks error in WorkflowNode.tsx (not a file changed by this PR, but your timing changes affect when it renders).

The issue is at line 791 in WorkflowNode.tsx:

// Update ReactFlow's internal handle positions when dynamic ports change.
const outputIds = effectiveOutputs.map((o) => o.id).join(',');
const inputIds = componentInputs.map((i) => i.id).join(',');
useEffect(() => {
  updateNodeInternals(id);
}, [id, outputIds, inputIds, updateNodeInternals]);

This useEffect is called AFTER the early return for !component (line 675). When component loads between renders, the hook count changes from 99 to 100, causing React to error.

Suggestion: Move this useEffect (and the calculations it depends on) BEFORE the early returns, using safe defaults like component?.inputs ?? [] when component is null.

This isn't caused by your changes - it's a pre-existing bug that your timing changes happen to expose. Happy to help fix it if needed!

Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
Signed-off-by: Krishna Mohan <krishanmohank974@gmail.com>
@betterclever betterclever merged commit c4d75bb into main Jan 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants