Refactor: Modularized project into src/ layout and integrated pytest-…#2
Open
JoseFelipeFerrada wants to merge 1 commit intoSebastianL18:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been using your library for my master thesis (it's been of great help! c: ) and wanted to make little changes. Mostly use more vectorized calculations from numpy. So i created a PyTest testsuit, added some test of pole retrieval and let the existing test as benchmark of speed and accuracy.
I have been thinking, are the assert i added meaningful? perhaps i should add something more dynamic?
i also added a toml file to make it more like a python library.
Hope it helps :)