Support BtreeMap and HashMap for deserialization using TryGetableFromJson#3009
Open
chinmaypandya wants to merge 5 commits intoSeaQL:masterfrom
Open
Support BtreeMap and HashMap for deserialization using TryGetableFromJson#3009chinmaypandya wants to merge 5 commits intoSeaQL:masterfrom
chinmaypandya wants to merge 5 commits intoSeaQL:masterfrom
Conversation
added 2 commits
March 15, 2026 01:37
…mJson
Implement `TryGetableFromJson` for `HashMap<K, V>` and `BTreeMap<K, V>` to
allow SeaORM to deserialize JSON database columns directly into these map
types.
This enables users to define entity fields such as:
BTreeMap<String, T>
HashMap<String, T>
for JSON columns without requiring custom wrapper types.
Added unit tests:
- json_deserialize_to_btreemap
- json_deserialize_to_hashmap
Member
|
Could you clean up the comments? A lot of them are unnecessary. |
Author
|
Yeah sure let me reduce the comments content |
Huliiiiii
reviewed
Mar 15, 2026
src/executor/query.rs
Outdated
|
|
||
| #[cfg(feature = "with-json")] | ||
| /// This implementation allows SeaORM to extract JSON database columns | ||
| /// directly into `HashMap<K, V>` using [`TryGetable`]. |
Author
There was a problem hiding this comment.
So no comments at all ? Should I also remove cfg feature ?
Member
There was a problem hiding this comment.
TryGetableFromJson requires with-json feature
Author
There was a problem hiding this comment.
Okay so I will just remove the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Field now supports BTreeMap and HashMap
New Features
TryGetableFromJsonforHashMap<K, V>andBTreeMap<K, V>toallow SeaORM to deserialize JSON database columns directly into these map
types.
This enables users to define entity fields such as:
for JSON columns without requiring custom wrapper types.
Added unit tests:
Example usage
Tests
Bug Fixes
Breaking Changes
Changes