Add Hashgraph Online skill manifest schema catalog entry#5409
Open
kantorcodes wants to merge 4 commits intoSchemaStore:masterfrom
Open
Add Hashgraph Online skill manifest schema catalog entry#5409kantorcodes wants to merge 4 commits intoSchemaStore:masterfrom
kantorcodes wants to merge 4 commits intoSchemaStore:masterfrom
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
kantorcodes
requested review from
hyperupcall and
madskristensen
as code owners
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
src/api/json/catalog.json
Outdated
| { | ||
| "name": "Hashgraph Online Skill Manifest", | ||
| "description": "Manifest for Hashgraph Online Registry Broker skill packages", | ||
| "fileMatch": ["skill.json", "**/.hol/skill.json", "hol-skill.json"], |
Contributor
There was a problem hiding this comment.
skill.json is a bit too generic. Can you narrow it in by adding a folder name, for instance?
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill.json,hol-skill.json, and**/.hol/skill.json)hashgraph-online/registry-broker-skillsValidation
node ./cli.js checkCloses #5405