Fixed image uploading, Improve image validation and tag handling #1986
+41
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New member button in the Navbar that links to the Samfundet member site using a constant defined in samf-three.ts. Also refactors cookie property check for impersonation to use Object.prototype.hasOwnProperty because it's safer and more reliable
Added validation to ensure the image file and title are provided and that the uploaded file is a valid image. Enhanced tag processing to strip whitespace, remove empty and duplicate tags, and preserve the original filename when saving the image.
StenOskar
requested review from
Snorre98,
andsamfu and
robines
as code owners
Fixed import and fix exception chaining
StenOskar
changed the base branch from
stenhalse/web-54-samf4-login-as-member
to
master
andsamfu
reviewed
Oct 30, 2025
Deleted an unused biome-ignore comment and cleaned up whitespaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason the image uploading failed was because the serializer did validation through full_clean(). The image model requires an image field, but the serializer excluded it. So validation ran before the image file was bounded to the model.
Also added validation to ensure the image file and title are provided and that the uploaded file is a valid image. Enhanced tag processing to strip whitespace, remove empty and duplicate tags, and preserve the original filename when saving the image.