Draft
Conversation
mnadareski
reviewed
Feb 24, 2026
mnadareski
reviewed
Feb 26, 2026
| using var aes = Aes.Create(); | ||
| #endif | ||
| aes.Key = [0xD1, 0xE3, 0xB3, 0x3A, 0x6C, 0x1E, 0xF7, 0x70, 0x5F, 0x6D, 0xE9, 0x3B, 0xB6, 0xC0, 0xDC, 0x71]; | ||
| aes.Mode = CipherMode.CBC; |
Collaborator
There was a problem hiding this comment.
I noticed the original code was using ECB, not CBC
Member
Author
There was a problem hiding this comment.
I basically implemened CBC in the python script with EBC, this should technically work. I need to debug this code but haven't got VS, so I need it to do a bunch of logging
Collaborator
There was a problem hiding this comment.
Oh, that's odd. If you do need to use EBC, it's available at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my initial attempt at implementing a repair mechanism into MPF for incomplete Xbox/360 SS files. It is a C# implementation of my (research-only) python script here: https://github.com/Deterous/ParseXboxMetadata/blob/main/RepairSS.py
I use the built-in Cryptography library for the AES computation, and a bunch of inscrutable logic for checking and shuffling around data. I still need to test this, but in the meantime a review of the code changes would be nice.
Note: This is necessary for OmniDrive SS dumps, as they are always incomplete. It is also required for any Kreon redumper dumps that are incomplete (such as when dumping with --kreon-partial-ss or just an unlucky SS read that failed for some reason).
Extra note: While this logic ideally runs in redumper not MPF, implementing the AES code in redumper's codebase is currently infeasible. MPF is the next best place.