Open
Conversation
Added the Maven Failsafe Plugin to run Integration Tests. UnitTest which require external devices is moved to integration-test phase.
Rewrote sonos-java assembly to include all dependencies(including itself) in the lib directory, and the launcher to the root directory. No need for "mvn clean dependency:copy-dependencies install assembly:assembly -Dmaven.test.skip=true" anymore, it is now done with "mvn clean package". changes in manifest: - Addded classpath "same as sonos-java.*.jar" - Mainclass changed to "org.tensin.sonos.commander.CLIController"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Serge
I looked into the issue I had with the classloader, mentioned here #8 (comment)
This pull request provide a more maven oriented solution.
As mentioned in the commit messages the result of this is that "mvn clean dependency:copy-dependencies install assembly:assembly -Dmaven.test.skip=true"
can be replaced with a "mvn clean package" command. This is, if both commits are accepted. This is only a change for the sonos-java destribution, and no files is removed from the result.
cheers
Phylock