fix: remove defaultEmoji and defaultCaption from emoji picker configu… #1148
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
This PR removes
defaultEmojianddefaultCaptionfrompreviewConfigto prevent a specific emoji from being displayed in the preview area when the emoji picker opens without any user interaction.With these defaults removed, the preview no longer shows a predefined emoji on initial render. Instead, the picker falls back to its internal placeholder/intro preview until the user hovers over or selects an emoji.
autoFocusis retained to preserve keyboard accessibility and match existing behavior.This aligns the embedded emoji picker behavior with expected UX and avoids showing a misleading default emoji on initial render.
Acceptance Criteria fulfillment
Fixes #1147
Video/Screenshots
emoji-picker-fix-pr.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace #1148 with the actual PR number.