-
Notifications
You must be signed in to change notification settings - Fork 92
build(deps-dev): Bump eslint from 7.22.0 to 9.26.0 #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 7.22.0 to 9.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/v9.26.0/CHANGELOG.md) - [Commits](eslint/eslint@v7.22.0...v9.26.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.26.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Greptile OverviewGreptile SummaryThis PR upgrades ESLint from version 7.22.0 to 9.26.0, spanning two major version bumps. However, this upgrade introduces critical breaking changes that will prevent ESLint from functioning:
Required actions before merging:
Confidence Score: 0/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Dep as Dependabot
participant CI as CI/Lint Pipeline
participant ESL as ESLint 9.26.0
participant Plugins as ESLint Plugins
participant Config as .eslintrc Config
Dep->>Dep: Detect ESLint 7.22.0 → 9.26.0 update
Dep->>Dev: Create PR #1693
Dev->>CI: Trigger lint check
CI->>ESL: Execute lint command
ESL->>Config: Load .eslintrc configuration
Config-->>ESL: ❌ Error: .eslintrc not supported (flat config required)
ESL->>Plugins: Load @typescript-eslint/parser v4.18.0
Plugins-->>ESL: ❌ Error: Incompatible with ESLint 9
ESL->>Plugins: Load eslint-plugin-* packages
Plugins-->>ESL: ❌ Error: Outdated plugin versions
ESL-->>CI: ❌ Linting fails
CI-->>Dev: ❌ Build/lint failure
Note over Dev,Config: Required fixes:<br/>1. Upgrade TS ESLint to v8/v9<br/>2. Upgrade all plugins<br/>3. Migrate to flat config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 3 comments
| "@typescript-eslint/eslint-plugin": "4.18.0", | ||
| "@typescript-eslint/parser": "4.18.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 9 introduces breaking changes: @typescript-eslint/eslint-plugin v4.18.0 and @typescript-eslint/parser v4.18.0 are incompatible with ESLint 9. These TypeScript ESLint packages require upgrade to v8.x or v9.x to work with ESLint 9.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 42:43
Comment:
ESLint 9 introduces breaking changes: `@typescript-eslint/eslint-plugin` v4.18.0 and `@typescript-eslint/parser` v4.18.0 are incompatible with ESLint 9. These TypeScript ESLint packages require upgrade to v8.x or v9.x to work with ESLint 9.
How can I resolve this? If you propose a fix, please make it concise.| "@typescript-eslint/eslint-plugin": "4.18.0", | ||
| "@typescript-eslint/parser": "4.18.0", | ||
| "eslint": "7.22.0", | ||
| "eslint": "9.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint 9 deprecated .eslintrc* configuration files in favor of flat config (eslint.config.js). The repository uses .eslintrc files which will not work with ESLint 9 by default unless ESLINT_USE_FLAT_CONFIG=false environment variable is set, but this is only a temporary compatibility layer.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 44:44
Comment:
ESLint 9 deprecated `.eslintrc*` configuration files in favor of flat config (`eslint.config.js`). The repository uses `.eslintrc` files which will not work with ESLint 9 by default unless `ESLINT_USE_FLAT_CONFIG=false` environment variable is set, but this is only a temporary compatibility layer.
How can I resolve this? If you propose a fix, please make it concise.
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: package.json
Line: 45:49
Comment:
ESLint 9 no longer supports these plugin versions. `eslint-config-prettier` v8.1.0, `eslint-plugin-import` v2.22.1, `eslint-plugin-jsdoc` v32.3.0, `eslint-plugin-monorepo` v0.3.2, and `eslint-plugin-prefer-arrow` v1.2.3 are all outdated and may not work with ESLint 9's flat config system.
How can I resolve this? If you propose a fix, please make it concise. |
Bumps eslint from 7.22.0 to 9.26.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
8bbabc49.26.016f5ff7Build: changelog update for 9.26.05b247c8chore: upgrade to@eslint/js@9.26.0(#19681)d6fa4acchore: package.json update for@eslint/jsreleasee9754e7feat: add reportGlobalThis to no-shadow-restricted-names (#19670)0fa2b7afeat: add suggestions foreqeqeqrule (#19640)dd98d63docs: Update README96e84defix: check cache file existence before deletion (#19648)c25e858docs: Update README0958690chore: disambiguate internal typesLanguageOptionsandRule(#19669)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.