[RFC] enable alternative installation and log path#1288
Open
Conversation
shrik3
commented
May 24, 2024
shrik3
commented
May 24, 2024
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
Signed-off-by: Tianhao Wang <shrik3@mailbox.org>
chl337
reviewed
Jun 23, 2024
Collaborator
There was a problem hiding this comment.
Could you please add a condition to check which files to copy over? It is annoying to get false negatives. I have a (semi) fix for that in the previous version, maybe do something similar.
Cheers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
motivation:
(especially for development) we don't want to use
sudoall the time. Also it doesn't make sense to hardcode the paths in the program.what's changing:
the makefile no longer uses
sudofor theinstalltarget, you may need to runsudo make installifmake installfails. Otherwise nothing changes if you don't modify the makefile.how to install to custom paths:
modify the makefile, and quark will use these paths for
qkernel,vdso.sobinary paths, config path and log path.and modify the
/etc/docker/daemon.jsonaccordingly.limitations
QLOG_DIR(yet). We can do it in the makefile.qserviceare still created under the default path/var/log/quarkbut they can opt in pretty easily.