retain storagetype in _ind_intersect
#161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
kshyatt
approved these changes
Jan 27, 2026
Jutho
reviewed
Jan 27, 2026
| @@ -120,7 +120,7 @@ end | |||
|
|
|||
| # when one of the ind selections is a bitvector, have to handle differently | |||
| function _ind_intersect(A::AbstractVector{Bool}, B::AbstractVector) | |||
Member
There was a problem hiding this comment.
Is it useful to special case
_ind_intersect(A::AbstractVector{Bool}, B::AbstractVector{Bool}) = A .& B
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this should also be tested somewhere, since this was failing on GPU before because the
falsesare allocated on the CPU.