Fix .dispense96() with List of Wells and Add Tests
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests aspirate96 accepted List[Well] in its type check but never assigned it to `containers`, causing an UnboundLocalError. Added the missing `else` branch to match dispense96. Added tests for dispense96 with a 384-well plate quadrant: backend call verification, wrong well count validation, mixed parent validation, and volume tracking. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the .dispense96() method to properly handle lists of wells as input, matching the existing behavior of .aspirate96(). The changes enable dispensing to arbitrary well lists (such as 384-well plate quadrants) and add comprehensive test coverage.
Changes:
- Added support for list of wells as input to
.dispense96()method - Improved error messages for invalid dispense operations
- Added three new test cases to verify well list functionality and error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pylabrobot/liquid_handling/liquid_handler.py | Added type checking and handling for list of wells in dispense96(), improved error message for plate with lid |
| pylabrobot/liquid_handling/liquid_handler_tests.py | Added import for 384-well plate and three new test cases covering well list dispense, mixed parent validation, and volume tracking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…hub.com/BioCam/pylabrobot into fix-dispense96-with-list-wells-and-add-tests
rickwierenga
approved these changes
Jan 30, 2026
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.