Support custom deserialize methods in serializer #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When deserializing a class, check if it defines a `deserialize` method in its own __dict__ (not inherited) and call it with the deserialized params. This enables classes like TipSpot to handle custom serialization fields (e.g., prototype_tip) that aren't __init__ parameters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deserializemethod in its own__dict__(not inherited) and call itTipSpotto handle custom serialization fields (e.g.,prototype_tip) that aren't__init__parametersTest plan
test_deserialize_calls_custom_deserialize_method🤖 Generated with Claude Code