Open
Conversation
Collaborator
Author
|
Cmd2 Changes are here: https://github.com/python-cmd2/cmd2/blob/cb0c75e6aa08573ea61ac26c04c8a74bce07188e/CHANGELOG.md?plain=1#L18 I also had to change the location of the 'prompt' class variable. |
daniel-montanari
requested changes
Jan 22, 2026
Collaborator
daniel-montanari
left a comment
daniel-montanari
left a comment
There was a problem hiding this comment.
Can you put something in the release notes about dropping python versions
Collaborator
Author
|
Yep sorry. Done now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
Somehow the lcr driver made it past CI without being formatted, and cmd2 got updated at the same time. As a result I need to bundle all these changes into the same PR to pass CI.