Match "." and "..." more strictly in coq-indent.el #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was prompted by issue ProofGeneral#853, which had the following example that didn't work properly: Axiom Ninterval: nat -> nat -> Prop. Notation "[ n '....' m ]" := (Ninterval n m). Notation "x 'BETWEEN' n 'AND' m " := ([n .... m] x) (at level 1). Axiom something_else : Prop. The problem was that the regex in coq-period-end-command would match "....", even though it's neither one nor three periods. Because I found the regexes quite hard to read, this commit also splits up the concats a bit, which I *think* makes them a bit easier.
rswarbrick
force-pushed
the
four-periods
branch
from
fb96beb to
b3157c6
Compare
Contributor
|
Thanks @rswarbrick . Sorry to be so slow to react. I will merge this quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by issue #853, which had the following example that didn't work properly:
The problem was that the regex in coq-period-end-command would match "....", even though it's neither one nor three periods.
Because I found the regexes quite hard to read, this commit also splits up the concats a bit, which I think makes them a bit easier.
Fixes #853.