Skip to content

Conversation

@naaa760
Copy link
Contributor

@naaa760 naaa760 commented Dec 2, 2025

fix: #19591

Overview

Support underscores in block names for consistency with variable naming rules.

Changes

  • Updated BlockDocumentName validation to allow underscores
  • Modified UI regex and error message
  • Updated tests to reflect new validation rules

Checklist

  • References related issue
  • Includes unit tests

Testing

  • ✅ Underscores now allowed: my_block, test-123_abc
  • ✅ Invalid chars still rejected: uppercase, spaces, special chars
  • ✅ Consistent validation across blocks and variables

@github-actions github-actions bot added enhancement An improvement of an existing feature ui-replatform Related to the React UI rewrite labels Dec 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #19592 will not alter performance

Comparing naaa760:feat/supp-under (57e1b11) with main (26aa8c6)

Summary

✅ 2 untouched

@zzstoatzz
Copy link
Collaborator

hi @naaa760 - thank you for the PR! however this is likely someone we'll need to deliberate internally, as this has implications across the full stack and prefect cloud

@zzstoatzz zzstoatzz marked this pull request as draft December 3, 2025 16:15
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An improvement of an existing feature status:stale ui-replatform Related to the React UI rewrite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support underscores for block names

2 participants