feat: add iOS native exception capture support #331
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'posthog_flutter': minor | ||
| --- | ||
|
|
||
| Add native exception capture support for Apple platforms (iOS, macOS, tvOS) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| package com.example.flutter | ||
|
|
||
| import io.flutter.embedding.android.FlutterActivity | ||
| import io.flutter.embedding.engine.FlutterEngine | ||
| import io.flutter.plugin.common.MethodChannel | ||
|
|
||
| class MainActivity : FlutterActivity() { | ||
| override fun configureFlutterEngine(flutterEngine: FlutterEngine) { | ||
| super.configureFlutterEngine(flutterEngine) | ||
|
|
||
| MethodChannel(flutterEngine.dartExecutor.binaryMessenger, "posthog_flutter_example") | ||
| .setMethodCallHandler { call, result -> | ||
| if (call.method == "triggerNativeCrash") { | ||
| NativeCrashHelper().triggerCrash() | ||
| result.success(null) | ||
| } else { | ||
| result.notImplemented() | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.example.flutter | ||
|
|
||
| /** | ||
| * Custom exception type for testing error tracking symbolication. | ||
| * This class will be minified by R8/ProGuard in release builds, | ||
| * allowing us to verify that symbolication (ProGuard mapping upload) works correctly. | ||
| */ | ||
| class PostHogExampleException(message: String) : Exception(message) | ||
|
|
||
| /** | ||
| * Helper class to trigger a native crash for testing error tracking. | ||
| * This class and its methods will be minified by R8/ProGuard in release builds, | ||
| * allowing us to verify that symbolication (ProGuard mapping upload) works correctly. | ||
| */ | ||
| class NativeCrashHelper { | ||
| fun triggerCrash() { | ||
| // Crash on a background thread because Flutter wraps and | ||
| // swallows exceptions from the method channel handler as | ||
| // a PlatformException, preventing the app from actually crashing. | ||
| Thread { | ||
| throw PostHogExampleException("Test native crash from PostHog Flutter example") | ||
| }.start() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,5 @@ | |
| <string>????</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>1.0</string> | ||
| </dict> | ||
| </plist> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| archiveVersion = 1; | ||
| classes = { | ||
| }; | ||
| objectVersion = 60; | ||
| objects = { | ||
|
|
||
| /* Begin PBXBuildFile section */ | ||
|
|
@@ -12,9 +12,11 @@ | |
| 331C808B294A63AB00263BE5 /* RunnerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 331C807B294A618700263BE5 /* RunnerTests.swift */; }; | ||
| 3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; }; | ||
| 74858FAF1ED2DC5600515810 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 74858FAE1ED2DC5600515810 /* AppDelegate.swift */; }; | ||
| 78A318202AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage in Frameworks */ = {isa = PBXBuildFile; productRef = 78A3181F2AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage */; }; | ||
| 97C146FC1CF9000F007C117D /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FA1CF9000F007C117D /* Main.storyboard */; }; | ||
| 97C146FE1CF9000F007C117D /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FD1CF9000F007C117D /* Assets.xcassets */; }; | ||
| 97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; }; | ||
| A1B2C3D4E5F60001AABBCCDD /* NativeCrashHelper.swift in Sources */ = {isa = PBXBuildFile; fileRef = A1B2C3D4E5F60000AABBCCDD /* NativeCrashHelper.swift */; }; | ||
| BDF5FF89BC2B236EF0B81DD2 /* Pods_RunnerTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BDC5BF357116FAB133D0276D /* Pods_RunnerTests.framework */; }; | ||
| /* End PBXBuildFile section */ | ||
|
|
||
|
|
@@ -45,24 +47,26 @@ | |
| 1498D2321E8E86230040F4C2 /* GeneratedPluginRegistrant.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GeneratedPluginRegistrant.h; sourceTree = "<group>"; }; | ||
| 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GeneratedPluginRegistrant.m; sourceTree = "<group>"; }; | ||
| 331C807B294A618700263BE5 /* RunnerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RunnerTests.swift; sourceTree = "<group>"; }; | ||
| 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = AppFrameworkInfo.plist; path = Flutter/AppFrameworkInfo.plist; sourceTree = "<group>"; }; | ||
| 552A4626DB9955B4837A84BA /* Pods-Runner.profile.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.profile.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.profile.xcconfig"; sourceTree = "<group>"; }; | ||
| 72D3235DB526308040CCA83E /* Pods-RunnerTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.debug.xcconfig"; path = "Target Support Files/Pods-RunnerTests/Pods-RunnerTests.debug.xcconfig"; sourceTree = "<group>"; }; | ||
| 74858FAD1ED2DC5600515810 /* Runner-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "Runner-Bridging-Header.h"; sourceTree = "<group>"; }; | ||
| 74858FAE1ED2DC5600515810 /* AppDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; }; | ||
| 74F175BA4BCEA03CB975D825 /* Pods-RunnerTests.profile.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.profile.xcconfig"; path = "Target Support Files/Pods-RunnerTests/Pods-RunnerTests.profile.xcconfig"; sourceTree = "<group>"; }; | ||
| 77D76B05F16B4B148310677D /* Pods-Runner.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.debug.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"; sourceTree = "<group>"; }; | ||
| 78E0A7A72DC9AD7400C4905E /* FlutterGeneratedPluginSwiftPackage */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = FlutterGeneratedPluginSwiftPackage; path = Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage; sourceTree = "<group>"; }; | ||
| 7AFA3C8E1D35360C0083082E /* Release.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; name = Release.xcconfig; path = Flutter/Release.xcconfig; sourceTree = "<group>"; }; | ||
| 7E9C12CB711543525381770A /* Pods-RunnerTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.release.xcconfig"; path = "Target Support Files/Pods-RunnerTests/Pods-RunnerTests.release.xcconfig"; sourceTree = "<group>"; }; | ||
| 9740EEB21CF90195004384FC /* Debug.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; name = Debug.xcconfig; path = Flutter/Debug.xcconfig; sourceTree = "<group>"; }; | ||
| 9740EEB31CF90195004384FC /* Generated.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; name = Generated.xcconfig; path = Flutter/Generated.xcconfig; sourceTree = "<group>"; }; | ||
| 97C146FB1CF9000F007C117D /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/Main.storyboard; sourceTree = "<group>"; }; | ||
| 97C146FD1CF9000F007C117D /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; }; | ||
| 97C147001CF9000F007C117D /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; }; | ||
| 97C147021CF9000F007C117D /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; }; | ||
| A1B2C3D4E5F60000AABBCCDD /* NativeCrashHelper.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NativeCrashHelper.swift; sourceTree = "<group>"; }; | ||
| A5B2412C165B920EC346A024 /* Pods-Runner.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.release.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"; sourceTree = "<group>"; }; | ||
| A809B0FA2F61A76C00637A80 /* Runner.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = Runner.app; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| A809B0FB2F61A76C00637A80 /* RunnerTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = RunnerTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| BD641B49EA0880C84FE2BD75 /* Pods_Runner.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_Runner.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| BDC5BF357116FAB133D0276D /* Pods_RunnerTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_RunnerTests.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| /* End PBXFileReference section */ | ||
|
|
@@ -80,6 +84,7 @@ | |
| isa = PBXFrameworksBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| 78A318202AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage in Frameworks */, | ||
| 3144428D6DB02E557C4ECAF0 /* Pods_Runner.framework in Frameworks */, | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
|
|
@@ -107,6 +112,7 @@ | |
| 9740EEB11CF90186004384FC /* Flutter */ = { | ||
| isa = PBXGroup; | ||
| children = ( | ||
| 78E0A7A72DC9AD7400C4905E /* FlutterGeneratedPluginSwiftPackage */, | ||
| 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */, | ||
| 9740EEB21CF90195004384FC /* Debug.xcconfig */, | ||
| 7AFA3C8E1D35360C0083082E /* Release.xcconfig */, | ||
|
|
@@ -136,7 +142,10 @@ | |
| 1498D2321E8E86230040F4C2 /* GeneratedPluginRegistrant.h */, | ||
| 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */, | ||
| 74858FAE1ED2DC5600515810 /* AppDelegate.swift */, | ||
| A1B2C3D4E5F60000AABBCCDD /* NativeCrashHelper.swift */, | ||
| 74858FAD1ED2DC5600515810 /* Runner-Bridging-Header.h */, | ||
| A809B0FA2F61A76C00637A80 /* Runner.app */, | ||
| A809B0FB2F61A76C00637A80 /* RunnerTests.xctest */, | ||
| ); | ||
| path = Runner; | ||
| sourceTree = "<group>"; | ||
|
|
@@ -173,7 +182,7 @@ | |
| ); | ||
| name = RunnerTests; | ||
| productName = RunnerTests; | ||
| productReference = A809B0FB2F61A76C00637A80 /* RunnerTests.xctest */; | ||
| productType = "com.apple.product-type.bundle.unit-test"; | ||
| }; | ||
| 97C146ED1CF9000F007C117D /* Runner */ = { | ||
|
|
@@ -187,15 +196,19 @@ | |
| 97C146EC1CF9000F007C117D /* Resources */, | ||
| 9705A1C41CF9048500538489 /* Embed Frameworks */, | ||
| 3B06AD1E1E4923F5004D2608 /* Thin Binary */, | ||
| 5C9C96BF1E7D401D439369FA /* [CP] Embed Pods Frameworks */, | ||
| A809B0FD2F61AD8000637A80 /* PostHog upload symbols */, | ||
| ); | ||
| buildRules = ( | ||
| ); | ||
| dependencies = ( | ||
| ); | ||
| name = Runner; | ||
| packageProductDependencies = ( | ||
| 78A3181F2AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage */, | ||
| ); | ||
| productName = Runner; | ||
| productReference = A809B0FA2F61A76C00637A80 /* Runner.app */; | ||
| productType = "com.apple.product-type.application"; | ||
| }; | ||
| /* End PBXNativeTarget section */ | ||
|
|
@@ -227,6 +240,9 @@ | |
| Base, | ||
| ); | ||
| mainGroup = 97C146E51CF9000F007C117D; | ||
| packageReferences = ( | ||
| 781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage" */, | ||
| ); | ||
| productRefGroup = 97C146EF1CF9000F007C117D /* Runner */; | ||
| projectDirPath = ""; | ||
| projectRoot = ""; | ||
|
|
@@ -295,20 +311,24 @@ | |
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" embed_and_thin\n"; | ||
| }; | ||
| 5C9C96BF1E7D401D439369FA /* [CP] Embed Pods Frameworks */ = { | ||
| isa = PBXShellScriptBuildPhase; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| ); | ||
| inputFileListPaths = ( | ||
| "${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks-${CONFIGURATION}-input-files.xcfilelist", | ||
| ); | ||
| inputPaths = ( | ||
| ); | ||
| name = "[CP] Embed Pods Frameworks"; | ||
| outputFileListPaths = ( | ||
| "${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks-${CONFIGURATION}-output-files.xcfilelist", | ||
| ); | ||
| outputPaths = ( | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks.sh\"\n"; | ||
|
|
@@ -327,7 +347,26 @@ | |
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" build\n"; | ||
| }; | ||
| A809B0FD2F61AD8000637A80 /* PostHog upload symbols */ = { | ||
| isa = PBXShellScriptBuildPhase; | ||
| alwaysOutOfDate = 1; | ||
| buildActionMask = 2147483647; | ||
| files = ( | ||
| ); | ||
| inputFileListPaths = ( | ||
| ); | ||
| inputPaths = ( | ||
| ); | ||
| name = "PostHog upload symbols"; | ||
| outputFileListPaths = ( | ||
| ); | ||
| outputPaths = ( | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "# uncomment to upload mapping files to PostHog\n# POSTHOG_INCLUDE_SOURCE=1 ${PODS_ROOT}/PostHog/build-tools/upload-symbols.sh\n"; | ||
|
Member
Author
There was a problem hiding this comment. @hpouillot uncomment this otherwise it wont trigger, had to remove it to make CI happy |
||
| }; | ||
| E0EB70FF4694C64F4A64348B /* [CP] Check Pods Manifest.lock */ = { | ||
| isa = PBXShellScriptBuildPhase; | ||
|
|
@@ -367,6 +406,7 @@ | |
| buildActionMask = 2147483647; | ||
| files = ( | ||
| 74858FAF1ED2DC5600515810 /* AppDelegate.swift in Sources */, | ||
| A1B2C3D4E5F60001AABBCCDD /* NativeCrashHelper.swift in Sources */, | ||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */, | ||
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
|
|
@@ -458,7 +498,7 @@ | |
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; | ||
| DEVELOPMENT_TEAM = PNC2XCH2XP; | ||
| ENABLE_BITCODE = NO; | ||
| INFOPLIST_FILE = Runner/Info.plist; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 13.0; | ||
|
|
@@ -641,7 +681,7 @@ | |
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; | ||
| DEVELOPMENT_TEAM = PNC2XCH2XP; | ||
| ENABLE_BITCODE = NO; | ||
| INFOPLIST_FILE = Runner/Info.plist; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 13.0; | ||
|
|
@@ -665,7 +705,7 @@ | |
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; | ||
| DEVELOPMENT_TEAM = PNC2XCH2XP; | ||
| ENABLE_BITCODE = NO; | ||
| INFOPLIST_FILE = Runner/Info.plist; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 13.0; | ||
|
|
@@ -715,6 +755,20 @@ | |
| defaultConfigurationName = Release; | ||
| }; | ||
| /* End XCConfigurationList section */ | ||
|
|
||
| /* Begin XCLocalSwiftPackageReference section */ | ||
| 781AD8BC2B33823900A9FFBB /* XCLocalSwiftPackageReference "Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage" */ = { | ||
| isa = XCLocalSwiftPackageReference; | ||
| relativePath = Flutter/ephemeral/Packages/FlutterGeneratedPluginSwiftPackage; | ||
| }; | ||
| /* End XCLocalSwiftPackageReference section */ | ||
|
|
||
| /* Begin XCSwiftPackageProductDependency section */ | ||
| 78A3181F2AECB46A00862997 /* FlutterGeneratedPluginSwiftPackage */ = { | ||
| isa = XCSwiftPackageProductDependency; | ||
| productName = FlutterGeneratedPluginSwiftPackage; | ||
| }; | ||
| /* End XCSwiftPackageProductDependency section */ | ||
| }; | ||
| rootObject = 97C146E61CF9000F007C117D /* Project object */; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hpouillot we need release mode and you cant run release mode on emulators