chore(dockerfiles/cd): run additional make targets to verify builder

[ti-chi-bot]

No description provided.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wuhuizuo for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ticdc/centos7 Docker builder by incorporating additional build steps. These steps compile various consumer components, ensuring that the builder environment is fully capable of producing all necessary artifacts, thereby improving the robustness of the build verification process.

Highlights

• Dockerfile Updates: Added new make commands to the ticdc/centos7/Dockerfile to build kafka_consumer, pulsar_consumer, and storage_consumer targets.
• Builder Verification: The newly added make targets are specifically for verifying the builder's capability to compile these components.

Changelog

• dockerfiles/cd/builders/ticdc/centos7/Dockerfile
  • Added RUN GOPROXY=${GOPROXY} make kafka_consumer pulsar_consumer storage_consumer -C /ws command to verify the builder.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds make targets to the centos7 TiCDC builder Dockerfile to verify the builder's capabilities. However, it introduces a potential command injection vulnerability by using the GOPROXY build argument without proper quoting in a RUN command, which could allow an attacker to execute arbitrary commands. Additionally, a similar change is missing in the rockylinux-based builder Dockerfile (dockerfiles/cd/builders/ticdc/Dockerfile), which should be addressed for consistent verification across all builders.

[gemini-code-assist]

The GOPROXY build argument is used in a RUN command without proper quoting, which can lead to a command injection vulnerability if an attacker controls its value. To remediate this, wrap the variable in double quotes. Additionally, for Docker image optimization, consider combining consecutive RUN commands into a single layer, potentially merging this make command with the preceding one to reduce image layers.

RUN GOPROXY="${GOPROXY}" make kafka_consumer pulsar_consumer storage_consumer -C /ws