Add simple Tkinter UI for AD join

[PierreGode]

Summary

• create adconnection_gui.py with a Tkinter-based interface for joining a Linux host to Active Directory
• document how to run the GUI in the README alongside the CLI Python app

Testing

• python3 -m py_compile adconnection_gui.py adconnection_app.py
• shellcheck ADconnection.sh (fails: command not found)

---

https://chatgpt.com/codex/tasks/task_e_684fe4864a1c8324b367ff75fc9a6526

[PierreGode]

AI Pull Request Summary:

Pull Request Analysis

---

Key Files and Components Modified

1. README.md
2. adconnection_app.py
3. adconnection_gui.py

---

Main Purpose of the Changes

The primary purpose of this pull request is to introduce new features that allow users to join a Linux host to Active Directory (AD) using Python scripts. This includes both a command-line interface (CLI) and a graphical user interface (GUI). The changes enhance the functionality of the existing AD join script by providing alternative methods for users to interact with the script.

---

Specific Functionalities Introduced, Modified, or Removed

1. README.md:

   • Added Instructions:
     • The README now includes instructions for using the new Python scripts:

       You can also use the Python version:
           sudo python3 adconnection_app.py [domain] [--user ADMIN] [--ou OU]
           sudo python3 adconnection_gui.py

   • This addition helps users understand how to utilize the new functionalities without needing prior knowledge of the scripts.

2. adconnection_app.py:

   • New File: This file introduces a CLI for joining a Linux host to AD.
   • Key Functions:
     • run_cmd(cmd): Executes shell commands and handles errors.
     • discover_domain(): Discovers the AD domain using the realm command.
     • join_domain(domain, admin_user, ou): Joins the specified domain.
     • main(): Entry point for the script which handles argument parsing and flow control.
   • Added Code (Highlighted Lines):
     • Lines defining the functions and the logic for joining the domain and discovering it.
     • Example of a significant section added:

       if __name__ == "__main__":
           main()

3. adconnection_gui.py:

   • New File: This file provides a GUI for users to join a Linux host to AD.
   • Key Functions:
     • Similar structure to the CLI, with a focus on user interaction through a Tkinter interface.
     • on_join(): Handles the join action triggered by the GUI button.
   • Added Code (Highlighted Lines):
     • Lines for creating the GUI layout and handling user input:

       root.mainloop()

---

Potential Implications or Considerations

• User Accessibility: The introduction of both a CLI and a GUI makes the script more accessible to different user demographics, including those who may not be comfortable with command-line interfaces.

• Performance: There are no immediate performance impacts noted; however, the reliance on subprocess calls may introduce slight overhead. Users should be aware of potential permission issues when executing commands.

• Dependencies: The new Python scripts require Python 3 and the Tkinter library. Users will need to ensure these are installed in their environment to utilize the GUI version.

• Breaking Changes: There are no breaking changes to existing functionality, but users relying solely on the previous shell script may need to adjust their usage patterns to take advantage of the new features.

• Documentation: The README has been updated to reflect these changes, which is critical for user guidance in utilizing the new scripts effectively.

---

Summary of Version

This pull request introduces a robust feature set for joining a Linux host to Active Directory, implemented via Python scripts (adconnection_app.py and adconnection_gui.py). The documentation in README.md has been updated to guide users in utilizing these new features. No bug fixes or corrections were indicated; the changes primarily serve to expand functionality and improve user experience.