fix: Fix SASS at-use import paths from node_modules. #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om docs and fix Markdown headers.
…n from docs and fix Markdown headers.
When using Patternslib in another project the relative node_module at-use rule imports might fail. This is now fixed as follows: - For the css Makefile compile target, define node_modules as load-path. - For the webpack compiler, the node_modules directory is already defined as load-path. - Change the at-use import in scss files for the defined node_modules import path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Patternslib in another project the relative node_module at-use rule imports might fail.
This is now fixed as follows:
Also: some minor documentation updates.