[mdaiter]: add CMake file for easier build#12
Open
mdaiter wants to merge 1 commit intoPascalPons:masterfrom
Open
[mdaiter]: add CMake file for easier build#12mdaiter wants to merge 1 commit intoPascalPons:masterfrom
mdaiter wants to merge 1 commit intoPascalPons:masterfrom
Conversation
mdaiter
commented
Apr 30, 2019
| * symetric positions are printed only once. | ||
| */ | ||
| void explore(const Position &P, char* pos_str, const int depth) { | ||
| void explore(const Position &P, char* const pos_str, const int depth) { |
Author
There was a problem hiding this comment.
Added a const-annotation to the pointer here to ensure memory safety and optimization
Owner
There was a problem hiding this comment.
This parameter is actually not const.
The code does not even compile with your suggestion.
Author
There was a problem hiding this comment.
Wait, the integer values are variable, but the pointer is const, no? I compiled on my machine and all of this worked;.
Owner
There was a problem hiding this comment.
my bad, sorry I misplaced the const when copying the code.
Author
|
@PascalPons , are we still trying to merge this? Wouldn't want the CMake file to go to waste. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile sometimes provides issues with temporary file generation and platform-specific compilers (
g++). CMake should help alleviate these issues.