add RequestMatcherInterface to RouterDecorator#21
Open
carlosromero wants to merge 10 commits intoPGSSoft:masterfrom
Open
add RequestMatcherInterface to RouterDecorator#21carlosromero wants to merge 10 commits intoPGSSoft:masterfrom
carlosromero wants to merge 10 commits intoPGSSoft:masterfrom
Conversation
…p-kernel-security-issue Resolves PGSSoft#18 Update symfony/http-kernel
Original object Router implements RouterInterface and RequestMatcherInterface Some bundles (EasyCorp/EasyAdmin) expects a Router object that implements RequestMatcherInterface and throws an exception in other case.
kjonski
reviewed
Nov 2, 2021
src/Decorator/RouterDecorator.php
Outdated
| { | ||
| return $this->getRouter()->matchRequest($pathinfo); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please remove this extra line
….root_dir deprecatd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kjonski,
First of all, thanks for sharing your bundle, I started using it recently and it works amazing in my app.
Some days ago I added https://github.com/EasyCorp/EasyAdminBundle to my app and then it started to complain about a interface matching issue within both bundles.
Original object Router implements RouterInterface and RequestMatcherInterface
Some bundles (EasyCorp/EasyAdmin) expects a Router object that implements RequestMatcherInterface and throws an exception in other case.
I resolved it with this commit and maybe you want add it also in you repository.
Regards!