Open
Conversation
|
lilsatya
reviewed
Dec 10, 2025
loburets
reviewed
Dec 10, 2025
|
|
||
| ### File Complexity | ||
|
|
||
| - **Maximum File Length**: 200 lines |
Contributor
There was a problem hiding this comment.
Not sure if this is realistic, some not complicated backend "services" files normally (now) can have 500-1000 lines.
If we do this, we should change the default structure to be like src/services/serviceName/serviceFile1.ts so they have room to growth
Contributor
Author
There was a problem hiding this comment.
its a guideline, not lint ;)
reviewing a new 1000 line file will be a chore.
there is an emphasis on changes made should be reviewable within 2 minutes.
loburets
reviewed
Dec 10, 2025
| ### Strict Mode Required | ||
|
|
||
| ```json | ||
| // tsconfig.json |
Contributor
There was a problem hiding this comment.
not sure LLM needs it as it's already in the project settings and handled by TS-checkers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.