fix: critical bugs and error handling improvements

[misterdas]

• Add custom error classes for DCP command handling (replaces magic strings)
• Validate purgeErrors.turns and turnProtection.turns >= 1 (prevents data loss)
• Replace silent error swallowing with console.error fallback in logger
• Add config validation warning for invalid turns values

Fixes:

• Magic string error control flow anti-pattern
• Potential immediate pruning of all errors with turns=0
• Silent error hiding in logger methods

[Tarquinen]

Hey, thanks for the help, couple questions:

Whats the point of the custom error classes? The error strings don't matter, they're not used anywhere they're just thrown to interrupt an opencode process.

Why only add numeric validation to some of the config fields? Should probably be done to everything?

Doesn't console.error log to the TUI?

[misterdas]

Thanks for the feedback! I've addressed your concerns:

1. Custom error classes - You're right, they were overkill. I've removed them and reverted to simple error strings for control flow. The strings aren't matched anywhere, so custom classes added unnecessary complexity.

2. Numeric validation - Fair point! I've expanded validation to all numeric fields:

• purgeErrors.turns - validate >= 1
• turnProtection.turns - validate >= 1
• nudgeFrequency - validate >= 1

Also added runtime clamping (Math.max(1, value)) for nudgeFrequency and purgeErrors.turns.

3. console.error to TUI - Good catch. I've added a devError method to the logger that only writes to the log file, never to console. This way errors are still captured for debugging without polluting the TUI.

Updated the PR with these changes. Let me know if anything else needs adjustment!

[Tarquinen]

I don't really get it, there's still a console.error? Won't that go to the TUI? did you try triggering it to verify? Also the format check is failing, run bun run format

[Tarquinen]

Looks good, thank you for the help!