Skip to content

Update missing init for VectorImageLayer#825

Merged
Kyle-Ye merged 7 commits intomainfrom
k-branch-1
Mar 15, 2026
Merged

Update missing init for VectorImageLayer#825
Kyle-Ye merged 7 commits intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 15, 2026

No description provided.

@github-actions github-actions bot added enhancement New feature or request RenderEffect labels Mar 15, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 15, 2026

🤖 Augment PR Summary

Summary: Completes missing vector-image layer initialization and adds CoreGraphics image conversion utilities.

Changes:

  • Implements `VectorImageLayer` initializers for CoreUI vector images, plus direct `CGPDFPage`/`CGSVGDocument` entry points (when CoreGraphics + CoreUI are available).
  • Adds drawable/cached `VectorImageContents` implementations that render vector content into an `ORBDisplayList` and optionally rasterize to `CGImage`.
  • Introduces protobuf encode/decode scaffolding for `VectorImageLayer` using display-list contents + size.
  • Adds `Image` initializers from `CGImage` and CoreGraphics helpers, including a `_CGBitmapContextCreate` shim for consistent bitmap context creation.
  • Updates the pinned revision of the DarwinPrivateFrameworks dependency.

Technical Notes: Vector-layer paths are gated behind canImport(CoreGraphics) and OPENSWIFTUI_LINK_COREUI, and retain catalog references when sourced from bundle-backed CoreUI catalogs.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye force-pushed the k-branch-1 branch 2 times, most recently from 4dff054 to 7582a3d Compare March 15, 2026 19:29
@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 0% with 259 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.17%. Comparing base (469a09a) to head (981af91).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../OpenSwiftUICore/View/Image/VectorImageLayer.swift 0.00% 132 Missing ⚠️
Sources/OpenSwiftUICore/View/Image/Image.swift 0.00% 114 Missing ⚠️
...penSwiftUICore/View/Image/CGImageConversions.swift 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   27.33%   27.17%   -0.16%     
==========================================
  Files         667      667              
  Lines       42706    42963     +257     
==========================================
+ Hits        11672    11674       +2     
- Misses      31034    31289     +255     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit c24fa1c into main Mar 15, 2026
6 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 15, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant