Skip to content

Add AccessibilityCore.UserSettings support#824

Merged
Kyle-Ye merged 7 commits intomainfrom
k-branch-1
Mar 15, 2026
Merged

Add AccessibilityCore.UserSettings support#824
Kyle-Ye merged 7 commits intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 15, 2026

No description provided.

@github-actions github-actions bot added enhancement New feature or request UX project UX related labels Mar 15, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 15, 2026

🤖 Augment PR Summary

Summary: This PR adds initial support for syncing system accessibility user settings into OpenSwiftUI’s environment.

Changes:

  • Introduces AccessibilityCore.UserSettings to resolve UIKit/Accessibility settings (e.g. Reduce Motion, Invert Colors, Button Shapes) into EnvironmentValues.
  • Adds an AccessibilityTechnologies SetAlgebra type plus environment plumbing for accessibilityEnabledTechnologies and per-technology convenience booleans.
  • Marks UIKitEnvironment as complete and wires trait/environment resolution to call UserSettings.resolve.
  • Begins WIP implementations for Large Content Viewer and Accessibility Quick Actions APIs (environment keys and public surface).
  • Expands PlatformItemList.Item to carry merged text/label/image metadata needed by accessibility features.
  • Adjusts accessibilityPlayAnimatedImages setter visibility to allow package-level updates.
  • Updates the Example Xcode project to link libAccessibility.tbd for the new Accessibility symbols.

Technical Notes: The new UIKit resolver uses several private C symbols (via @_silgen_name) to read additional accessibility flags.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 0% with 196 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.32%. Comparing base (cd3b4ff) to head (9e153a3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Accessibility/AccessibilityLargeContentView.swift 0.00% 75 Missing ⚠️
...ftUI/Accessibility/AccessibilityTechnologies.swift 0.00% 54 Missing ⚠️
...iftUI/Accessibility/AccessibilityQuickAction.swift 0.00% 36 Missing ⚠️
...essibility/AccessibilityEnvironmentAdditions.swift 0.00% 25 Missing ⚠️
...ces/OpenSwiftUI/Integration/PlatformItemList.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   27.46%   27.32%   -0.14%     
==========================================
  Files         663      667       +4     
  Lines       42510    42706     +196     
==========================================
- Hits        11674    11671       -3     
- Misses      30836    31035     +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 469a09a into main Mar 15, 2026
8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 15, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request platform: iOS platform: macOS UX project UX related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant