Skip to content

Update ORBDisplayList API and add encoding protocols#25

Merged
Kyle-Ye merged 6 commits intomainfrom
update-display-list-api
Mar 10, 2026
Merged

Update ORBDisplayList API and add encoding protocols#25
Kyle-Ye merged 6 commits intomainfrom
update-display-list-api

Conversation

@Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Mar 10, 2026

Summary

  • Add full ORBDisplayList API surface (properties, drawing, filters, styles, layers, transforms)
  • Add ORBDisplayListContents and ORBDisplayListInterpolator protocols/classes
  • Add encoding protocols: ORBEncodable, ORBDecodable, ORBEncoderDelegate, ORBDecoderDelegate, ORBEncoderSet
  • Move _ORBDrawableDelegate.h and add _ORBDisplayListContents.h to Render/Private/
  • Add CF_RETURNS_NOT_RETAINED to beginCGContextWithAlpha: for clean Swift bridging
  • Update OpenRenderBoxShims typealiases and DarwinPrivateFrameworks dependency

Test plan

  • Compatibility tests pass (DisplayListTests: init, properties, beginEndCGContext, moveContents, NSImage)
  • Verify swift build on non-Darwin platforms

@Kyle-Ye Kyle-Ye force-pushed the update-display-list-api branch from 6bf56bb to dacf2da Compare March 10, 2026 17:57
@Kyle-Ye Kyle-Ye merged commit d870b22 into main Mar 10, 2026
4 checks passed
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 159 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (9a04f86) to head (dacf2da).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenRenderBox/Render/ORBDisplayList.swift 0.00% 138 Missing ⚠️
...nRenderBox/Render/ORBDisplayListInterpolator.swift 0.00% 21 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #25    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          6       8     +2     
  Lines        197     356   +159     
======================================
- Misses       197     356   +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye deleted the update-display-list-api branch March 10, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants