fix(api/remove): add validation for empty items in delete file list #1617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Req.Names contains an empty string item, the whole directory will be removed. As a result we need add a simple guard to prevent such cases. Signed-off-by: huyuantao <huyuantao@ultrarisc.com>
jyxjjj
changed the title
jyxjjj
previously approved these changes
Dec 15, 2025
KirCute
requested changes
Dec 15, 2025
…etion 1. Use `utils.FixAndCleanPath` to correctly identify and block invalid names. 2. Change error handling from `return` to `continue`. Signed-off-by: huyuantao <huyuantao@ultrarisc.com>
KirCute
approved these changes
Dec 16, 2025
xrgzs
added
Module: Filesystem
xrgzs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / 描述
FsRemove 如果 Req.Names 存在空的 item，那么整个目录都会被删除，因此需要进行空字符串检查
本人无 label 增加权限，若适用请管理员增加 bug 标签
Motivation and Context / 背景
在使用过程中，选中一个子项并进行删除操作，整个目录被删除，该现象无法复现。不过可以通过 api 复现，对于
/api/fs/remove接口，如果 names 存在空字符串则则整个目录会被删除。How Has This Been Tested? / 测试
测试
/api/fs/remove参考的 body
{ "dir":"/data/temp/ssh", "names":[""] }Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。