Skip to content

fix: prevent silent None return in run_with_retry when max_retries < 1 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent silent None return in run_with_retry when max_retries < 1 #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29d7f2d
fix: prevent silent None return in run_with_retry when max_retries < 1
amathxbt Mar 21, 2026
71c5004
fix: restore and update _utils.py with proper merge from main
amathxbt Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/opengradient/client/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from pathlib import Path
from typing import Callable

from .exceptions import OpenGradientError

_ABI_DIR = Path(__file__).parent.parent / "abi"
_BIN_DIR = Path(__file__).parent.parent / "bin"

Expand All @@ -22,7 +20,8 @@ def get_abi(abi_name: str) -> dict:
"""Returns the ABI for the requested contract."""
abi_path = _ABI_DIR / abi_name
with open(abi_path, "r") as f:
return json.load(f)
result: dict = json.load(f)
return result


def get_bin(bin_name: str) -> str:
Expand Down Expand Up @@ -50,6 +49,9 @@ def run_with_retry(
"""
effective_retries = max_retries if max_retries is not None else DEFAULT_MAX_RETRY

if effective_retries < 1:
raise ValueError(f"max_retries must be at least 1, got {effective_retries}")

for attempt in range(effective_retries):
try:
return txn_function()
Expand All @@ -58,8 +60,10 @@ def run_with_retry(

if any(error in error_msg for error in _NONCE_ERRORS):
if attempt == effective_retries - 1:
raise OpenGradientError(f"Transaction failed after {effective_retries} attempts: {e}")
raise RuntimeError(f"Transaction failed after {effective_retries} attempts: {e}")
time.sleep(retry_delay)
continue

raise

raise RuntimeError(f"run_with_retry exhausted {effective_retries} attempts without returning or raising")
Loading