Fixing flaky tests #70
Conversation
…e runners for the matrix
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 88.16% 87.05% -1.11%
==========================================
Files 7 7
Lines 338 340 +2
==========================================
- Hits 298 296 -2
- Misses 40 44 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| assert ts.time == times[inx] | ||
| assert np.all(u.atoms.positions > 0) | ||
| # Positions are not all zero since PBC is not removed | ||
| assert np.any(u.atoms.positions != 0) |
There was a problem hiding this comment.
@IAlibay : This is what I mentioned yesterday. The positions in this nc file are not always >0.
There was a problem hiding this comment.
Ok thanks, that's interesting..
There was a problem hiding this comment.
When I add this u.trajectory.add_transformations(wrap(u.atoms)) it passes the >0 check.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
| base_url=ZENODO_DOI, | ||
| registry=ZENODO_FILES, |
There was a problem hiding this comment.
glad you're doing this! it's what I'm moving us toward on the openfe side.
|
@hannahbaumann you'll want to build pooch from |
| yield u | ||
| u.trajectory.close() |
There was a problem hiding this comment.
No, xtc files, and trajectories in MDAnalysis overall, do not need this - close should get called on garbage collection and xtc files don't have concurrency issues.
Fixes #43 and #67
This PR: