SeaState: Small change in WavePkShp logic#3202
Merged
deslaughter merged 3 commits intoOpenFAST:devfrom Feb 13, 2026
Merged
Conversation
Contributor
|
@RBergua Thanks for catching this. I'm not aware of |
luwang00
approved these changes
Feb 13, 2026
deslaughter
reviewed
Feb 13, 2026
Change for floating-point precision. Co-authored-by: Derek Slaughter <dslaught@nrel.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
In SeaState, the peak-shape parameter only plays a role when using
WaveMod= 2 (JONSWAP/Pierson-Moskowitz spectrum (irregular)).However, nowadays, there is no logic that checks this. For example, if the user defines still water (
WaveMod= 0) or a regular wave (e.g.,WaveMod= 1), SeaState still checks internally for a validWavePkShpinput value and it aborts the program if the criteria is not met.This modification, checks for a valid
WavePkShponly ifWaveMod= 2.@luwang00: Internally, if the user is not using
WaveMod= 2, I'm assigning a dummy value ofWavePkShp= 1. I don't know if you use thisWavePkShpsomewhere else and not having a 'valid'WavePkShpcould break the code down the road. If there is no need to have aWavePkShp, I could remove the else statement in the proposed code. I did this change to have something robust.