Makefile: align cargo make all with CI checks#93
Merged
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom Mar 12, 2026
Merged
Makefile: align cargo make all with CI checks#93makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
cargo make all with CI checks#93makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
Conversation
Javagedes
requested changes
Mar 12, 2026
Contributor
Javagedes
left a comment
Javagedes
left a comment
There was a problem hiding this comment.
If we are going to do this, then we should also update the CI workflow to call these new tasks instead of the direct cargo <cmd> calls they currently do.
The `all` task previously ran `fmt` (which applies formatting) instead of checking it, and was missing `doc-test`. This caused `cargo make all` to not catch the same issues that CI catches. Additionally, CI called `cargo fmt --all --check` and `cargo test --doc` directly instead of using cargo-make tasks. - Add `fmt-check` task (`cargo fmt --all --check`) to all Makefiles - Add `doc-test` task (`cargo test --doc`) to all Makefiles - Replace `fmt` with `fmt-check` in `all` dependencies (moved first for fast failure) - Add `doc-test` to `all` dependencies - Update CiWorkflow.yml to use `cargo make fmt-check` and `cargo make doc-test`
kat-perez
force-pushed
the
cargo-make-all-match-ci
branch
from
d5d6f8d to
eb6b295
Compare
Contributor
Author
Updated to call the new tasks |
Javagedes
approved these changes
Mar 12, 2026
makubacki
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cargo make alltask is intended for local PR readiness validation, but it diverges from what CI actually checks in two ways:fmtvsfmt --check: Thealltask rancargo fmt --all(which silently fixes formatting) instead ofcargo fmt --all --check(which fails on unformatted code like CI does). This meanscargo make allwould never catch formatting issues.Missing
cargo test --doc: CI runscargo test --docseparately, butcargo make alldidn't include it.How this was tested
Ran
cargo make fmt-check,cargo make doc-test, andcargo make alllocally in the patina repo with the equivalent changes applied.