Skip to content

Bump for php8.5 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kletord merged 2 commits into from
Mar 4, 2026
Merged

Bump for php8.5 #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f22c8
Bump for php8.5
kletord Mar 4, 2026
5f7061b
Fix php >=8.4 deprecations
kletord Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
runs-on: ubuntu-24.04
strategy:
matrix:
php-versions: [ '8.2', '8.3', '8.4' ]
symfony-version: ['5.4.*', '6.4.*', '7.2.*']
php-versions: [ '8.3', '8.4', '8.5' ]
symfony-version: ['6.4.*', '7.4.*']
fail-fast: false
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions Services/Event/Impl/EventFactoryImpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ class EventFactoryImpl implements EventFactory
*/
public function make(
$eventName,
UseCaseRequest $useCaseRequest = null,
UseCaseResponse $useCaseResponse = null,
\Exception $exception = null
?UseCaseRequest $useCaseRequest = null,
?UseCaseResponse $useCaseResponse = null,
?\Exception $exception = null
) {
return $this->useCaseEventBuilder
->create()
Expand Down
6 changes: 3 additions & 3 deletions Services/Event/Impl/UseCaseEventBuilderImpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function named($name)
/**
* @return UseCaseEventBuilder
*/
public function withUseCaseRequest(UseCaseRequest $useCaseRequest = null)
public function withUseCaseRequest(?UseCaseRequest $useCaseRequest = null)
{
if (null !== $useCaseRequest) {
$this->event->setUseCaseRequest($useCaseRequest);
Expand All @@ -51,7 +51,7 @@ public function withUseCaseRequest(UseCaseRequest $useCaseRequest = null)
/**
* @return UseCaseEventBuilder
*/
public function withUseCaseResponse(UseCaseResponse $useCaseResponse = null)
public function withUseCaseResponse(?UseCaseResponse $useCaseResponse = null)
{
if (null !== $useCaseResponse) {
$this->event->setUseCaseResponse($useCaseResponse);
Expand All @@ -63,7 +63,7 @@ public function withUseCaseResponse(UseCaseResponse $useCaseResponse = null)
/**
* @return UseCaseEventBuilder
*/
public function withUseCaseException(\Exception $exception = null)
public function withUseCaseException(?\Exception $exception = null)
{
if (null !== $exception) {
$this->event->setUseCaseException($exception);
Expand Down
6 changes: 3 additions & 3 deletions Services/Event/UseCaseEventBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@ abstract public function named($name);
* @return UseCaseEventBuilder
* @codeCoverageIgnore
*/
abstract public function withUseCaseRequest(UseCaseRequest $useCaseRequest = null);
abstract public function withUseCaseRequest(?UseCaseRequest $useCaseRequest = null);

/**
* @return UseCaseEventBuilder
* @codeCoverageIgnore
*/
abstract public function withUseCaseResponse(UseCaseResponse $useCaseResponse = null);
abstract public function withUseCaseResponse(?UseCaseResponse $useCaseResponse = null);

/**
* @return UseCaseEventBuilder
* @codeCoverageIgnore
*/
abstract public function withUseCaseException(\Exception $exception = null);
abstract public function withUseCaseException(?\Exception $exception = null);

/**
* @return UseCaseEvent
Expand Down
16 changes: 8 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@
}
},
"require": {
"php": ">=8.2",
"openclassrooms/use-case": "^2.0",
"symfony/cache": "~5.4 || ~6.4 || ~7.1",
"symfony/dependency-injection": "~5.4 || ~6.4 || ~7.1",
"symfony/config": "~5.0 || ~6.4 || ~7.1",
"symfony/http-kernel": "~5.0 || ~6.4 || ~7.1 || ~7.1",
"symfony/security-core": "~5.0 || ~6.4 || ~7.1",
"php": ">=8.3",
"openclassrooms/use-case": "^2.0 || ^3.0",
"symfony/cache": "^6.4 || ^7.4",
"symfony/dependency-injection": "^6.4 || ^7.4",
"symfony/config": "^6.4 || ^7.4",
"symfony/http-kernel": "^6.4 || ^7.4",
"symfony/security-core": "^6.4 || ^7.4",
"doctrine/orm": "~2.3 || ~3.2",
"doctrine/dbal": "~3.2",
"symfony/event-dispatcher": "~5.0 || ~6.4 || ~7.1"
"symfony/event-dispatcher": "^6.4 || ^7.4"
},
"require-dev": {
"phpunit/phpunit": "^10"
Expand Down