Skip to content

Linh – Fix Educator Task Submissions UI + Late Submission Detection Improvements#4486

Open
linh2020 wants to merge 1 commit intodevelopmentfrom
linh_educator_taskSubmissions_frontend_uiFilter
Open

Linh – Fix Educator Task Submissions UI + Late Submission Detection Improvements#4486
linh2020 wants to merge 1 commit intodevelopmentfrom
linh_educator_taskSubmissions_frontend_uiFilter

Conversation

@linh2020
Copy link
Contributor

@linh2020 linh2020 commented Dec 3, 2025

Description

This PR fixes the backend and frontend issues preventing the Educator Task Submissions page from working correctly and completes missing logic requested by Harshitha & Sphurthy.
The previous PR (#4207 frontend, #1799 backend) implemented the UI but failed to load or filter student submissions due to missing studentId and incorrect filtering logic.
This PR resolves those issues and adds improved functionality.

Related PRS (if any):

This frontend PR is related to the backend PR#1934

Main changes explained:

  • Updated frontend to use new studentId correctly
  • Fixed filter logic so:
    "All Submissions" → returns all
    "Pending Review" → only pending
    "Graded" → only graded
    Before: always returned full list
    After: correct filtering based on backend data
  • Ensured data groups by:
    lessonPlanId → classes
    taskName → task groups inside each class
  • Verified UI components load successfully after backend fix
    TaskSubmissionsPage
    SubmissionCard
    Tabs, dropdown, tooltips, card states

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. Login and Navigation:
    Login with an educator account
    Navigate to /educationportal/educator/task-submissions
    Verify the page loads with submission data

Verify:
Tabs load class names
Tasks expand correctly
Cards show:
pending → info tooltip
graded → badge
late → red styling
Filtering toggles results properly
No more infinite loading or 404/401 issues

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

@netlify
Copy link

netlify bot commented Dec 3, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ebbb846
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/692fef7ca0b48000080732e8
😎 Deploy Preview https://deploy-preview-4486--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@linh2020 linh2020 changed the title Linh - Fixed educator task submissions UI with late submission tagging Linh – Fix Educator Task Submissions UI + Late Submission Detection Improvements Dec 3, 2025
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 21, 2025
Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Linh,

I have reviewed your PR locally and as you can see in the below video, the huge unnecessary data i.e neither graded or pending review is causing lag and is breaking the mobile responsiveness.
Screenshot 2025-12-24 at 5 20 49 PM

4486.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants