Skip to content

Sundar: 🔥 sonar duplicate code in bmFinancialController#2087

Merged
one-community merged 1 commit intodevelopmentfrom
sundar/sonar-pr2086
Mar 6, 2026
Merged

Sundar: 🔥 sonar duplicate code in bmFinancialController#2087
one-community merged 1 commit intodevelopmentfrom
sundar/sonar-pr2086

Conversation

@sundarmachani
Copy link
Contributor

Description

Please include the exact bug/functionality description and a summary of the changes/ related issues. Please also include any other relevant motivation and context:
Fixes # (bug list priority high/medium/low x.y.z)
Or Implements # (WBS)

Related PRS (if any):

This frontend PR is related to the #XXX backend PR.
To test this backend PR you need to checkout the #XXX frontend PR.

Main changes explained:

  • Delete file A for removing unused components …
  • Update file B for including new pattern …
  • Create file C for introducing new components …

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to dashboard→ Tasks→ task→…
  6. verify function “A” (feel free to include screenshot here)

Screenshots or videos of changes:

Note:

Include the information the reviewers need to know.

@sundarmachani sundarmachani changed the title fix: Fix sonar duplicate code in bmFinancialController Sundar: Fix sonar duplicate code in bmFinancialController Mar 6, 2026
@one-community one-community merged commit fe90d2c into development Mar 6, 2026
2 checks passed
@one-community one-community changed the title Sundar: Fix sonar duplicate code in bmFinancialController Sundar: 🔥 sonar duplicate code in bmFinancialController Mar 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants