-
Notifications
You must be signed in to change notification settings - Fork 710
Introduce MachineLocator for Validator #4350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4350 +/- ##
==========================================
+ Coverage 32.88% 33.05% +0.16%
==========================================
Files 489 489
Lines 58002 58002
==========================================
+ Hits 19076 19174 +98
+ Misses 35576 35451 -125
- Partials 3350 3377 +27 |
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Contributor
❌ 8 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
pmikolajczyk41
requested changes
Feb 10, 2026
gligneul
reviewed
Feb 10, 2026
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
pmikolajczyk41
previously approved these changes
Feb 11, 2026
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor request, otherwise LGTM
gligneul
previously approved these changes
Feb 11, 2026
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
860270b
pmikolajczyk41
approved these changes
Feb 12, 2026
gligneul
approved these changes
Feb 12, 2026
eljobe
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
MachineLocatorfor Rust Validator. Currently Validator can handle multiple module roots; however it can only find one (through command line). This PR introducesMachineLocator, which its responsibility is to look for replay.wasm machines locations relative to where Validator is running. Such machines are later on started byJitProcessManager. That also simulates the same behaviour of Validator that's implemented in Go, with the caveat that Rust Validator only looks for such machine at startup.closes NIT-4346