Open
Conversation
…ing append mode "a", which caused consequtive writes to grow the tiffile by the given domain of the dataitem. This was never a problem as geodms handled temporary (.tmp) files itself and deleted these accordingly. Changing "a" to "w" makes sure that a new tif file is always created on write, which is in line with the new state: new writes always to fresh files.
Collaborator
|
Wat als in dezelfde dan wel opvolgende sessies GridData en PaletteData worden berekend en gecommit, of eerst PaletteData en dan GridData? |
Collaborator
Author
|
Release unit tests all passed. So the question becomes: is palette data properly tested in the unit tests? The best way would be to collect palette data if necessary and do the write once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tif files openened/created for writing were opened using append mode "a", which caused consequtive writes to grow the tiffile usually by the given domain of the dataitem. This was never a problem as geodms handled temporary (.tmp) files itself and deleted these accordingly. Changing "a" to "w" makes sure that a new tif file is always created on write, which is in line with the new state: new writes to storage targets are always done to fresh files.