Skip to content

fix: explicitly use FAILSAFE_SCHEMA for yaml.load() security hardening #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khushal-winner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: explicitly use FAILSAFE_SCHEMA for yaml.load() security hardening #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cornucopia.owasp.org/src/lib/services/capecService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class CapecService {
`${__dirname}${this.path}${edition}-capec-${version}.yaml`,
'utf8'
);
const data = yaml.load(yamlData) as CapecData;
const data = yaml.load(yamlData, { schema: yaml.FAILSAFE_SCHEMA }) as CapecData;
this.capecData.set(key, data);
return data;
} catch (e) {
Expand Down
2 changes: 1 addition & 1 deletion cornucopia.owasp.org/src/lib/services/deckService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class DeckService {
}

let yamlData = fs.readFileSync(cardFile, 'utf8');
let data = yaml.load(yamlData);
let data = yaml.load(yamlData, { schema: yaml.FAILSAFE_SCHEMA });
let base = `data/cards/${edition}-cards-${version}-${lang}/`;

if (!FileSystemHelper.hasDir(base)) {
Expand Down
6 changes: 3 additions & 3 deletions cornucopia.owasp.org/src/lib/services/mappingService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class MappingService {
public getLatestsCardMappingData(edition: string)
{
const yamlData = fs.readFileSync(`${__dirname}${MappingService.path}${edition}-mappings-${DeckService.getLatestVersion(edition)}.yaml`, 'utf8');
let data = yaml.load(yamlData);
let data = yaml.load(yamlData, { schema: yaml.FAILSAFE_SCHEMA });
MappingService.mappings.push({edition: edition, version: 'latests', data: data});
return data;
}
Expand All @@ -24,7 +24,7 @@ export class MappingService {
{
DeckService.getDecks().forEach((deck) => {
const yamlData = fs.readFileSync(`${__dirname}${MappingService.path}${deck.edition}-mappings-${deck.version}.yaml`, 'utf8');
let data = yaml.load(yamlData);
let data = yaml.load(yamlData, { schema: yaml.FAILSAFE_SCHEMA });
MappingService.mappings.push({edition: deck.edition, version: deck.version, data: data});
});

Expand Down Expand Up @@ -60,7 +60,7 @@ export class MappingService {
if (!mappingData) {
try {
const yamlData = fs.readFileSync(`${__dirname}${MappingService.path}${deck.edition}-mappings-${deck.version}.yaml`, 'utf8');
mappingData = yaml.load(yamlData);
mappingData = yaml.load(yamlData, { schema: yaml.FAILSAFE_SCHEMA });
MappingService.mappings.push({edition: deck.edition, version: deck.version, data: mappingData});
} catch (e) {
console.error(`Failed to load mapping for ${deck.edition}-${deck.version}:`, e);
Expand Down
Loading