Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fine-tuned ZAP scan configuration to reduce report phase duration while maintaining active scan coverage.
Problem
The Ajax Spider phase had no duration limit, which caused the report generation phase to exceed the GitHub Actions 6-hour limit.
Changes
.github/workflows/zap-nightly-scan.yml
ajaxSpider.maxDuration=10to cap the spider phase at 10 minutesscanner.maxScanDurationInMins=180remains unchangedHow it was tested
Multiple spider and scan duration combinations were tested to find the optimal fit within GitHub Actions time limits. The two best candidates were
ajaxSpider.maxDuration=10withscanner.maxScanDurationInMins=180(~3h 21m), andajaxSpider.maxDuration=20withscanner.maxScanDurationInMins=120(~3h). The 10/180 configuration was chosen as it dedicates more time to active scanning.