fix: add transaction protection to card dealing to prevent game state corruption#2348
fix: add transaction protection to card dealing to prevent game state corruption#2348Arunodoy18 wants to merge 4 commits intoOWASP:masterfrom
Conversation
Fixes OWASP#2133 Problem: The first suit table (VE - Data Validation & Encoding) in both guide template variants had inconsistent row heights compared to all other suit tables, causing text overflow in translations with longer content. Standard template (owasp_cornucopia_webapp_ver_guide_bridge_lang.odt): - Table10.2: 3.501cm (should be 4.001cm) - Table10.3: 4.501cm (should be 4.001cm) QR template (owasp_cornucopia_webapp_ver_guide_bridge_qr_lang.odt): - Table11.4: 3.501cm (should be 4.001cm) All other suit tables (17/18 through 87/95) use 4.001cm uniformly. Solution: Normalized the inconsistent row heights to 4.001cm to match the standard used by all other suit tables. This provides consistent vertical spacing across all card descriptions and prevents text overflow issues in non-English translations. Changes: - Fixed row heights in both guide template variants - Added fix_templates_issue_2133.py script for reproducibility - Updated .gitignore to exclude .backup files
Arunodoy18
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
|
@Arunodoy18 Make sure your commits have a verified signature |
|
Make sure you update your branch as well. |
fix_templates_issue_2133.py
Outdated
There was a problem hiding this comment.
This seems to be unrelated to transaction protection. Please remove file.
…lidation with transactional card dealing
|
Hi @sydseter, I've addressed all the requested changes: Resolved the merge conflict in show.ex, combining your upstream 3-player validation with the transactional card dealing logic |
|
Hi @sydseter, I've addressed all the requested changes:
Branch is now up to date with \upstream/master. Ready for re-review. |
|
@Arunodoy18 serious ?!!, it was assigned to me , please make sure to only work on issue assign to u |
|
@Arunodoy18 hope u will close the pr and wonot create dublicate pr for the issue found by other(me) and assign to other !! 🙂 |
3 participants
Fixes issue #2343.
Complies with ASVS V2.3.3 for business-logic-level transaction integrity.