Skip to content

Conversation

Copy link

Copilot AI commented Jan 18, 2026

Proxy fields are computed values accessed via getter/setter methods and should not be persisted to project files. Previously, each proxy field required explicit xmlCapability()->disableIO() calls throughout the codebase.

Changes

  • Template specialization: Added PdmFieldXmlCap<PdmProxyValueField<DataType>> that calls disableIO() in constructor

    • Applies to all proxy fields automatically at initialization
    • Implementation in cafInternalPdmXmlFieldCapability.h and .inl
  • Cleanup: Removed 32 redundant disableIO() calls across ApplicationLibCode

    • Affects proxy fields in Surfaces, Seismic, Completions, Summary, WellPath, etc.
    • Example change in RimSurface.cpp:
      // Before
      m_nameProxy.xmlCapability()->disableIO();
      
      // After
      // (no explicit call needed)
  • Test coverage: Added ProxyFieldIODisabled test verifying:

    • Proxy fields have isIOReadable() and isIOWritable() both false
    • Regular fields maintain default IO enabled behavior

Files changed: 29 files (+104, -32 lines)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • community.opengroup.org
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED u/13/collect2 clon�� u/13/liblto_plugin.so _64-linux-gnu/13/lto-wrapper SAnAYv.res --depth o ead inja conf�� 9 -Wall -Wno-unk-o --local tnet/tools/as esInsight/build/git (dns block)
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin REDACTED u/13/cc1 remo�� origin REDACTED g openmp -DUSE_OPENMP -Wfatal-errors -Wall -Wno-REDACTED-pragmas -Wno-unused-result -Wno-unused-pa (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>AppFwk : Disable default IO for proxy fields</issue_title>
<issue_description>Currently, proxy fields are stored in project file. Change default behavior of proxy fields to default behavior with no IO.

Make sure all PdmProxyValueField disables Xml read and write features

xmlCapability()->setIOWritable(false)
xmlCapability()->setIOReadable(false)

Consider setting this in constructor. If this is done, remove explicit calls to in client code.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 4 commits January 18, 2026 09:24
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
…t forward declaration

Co-authored-by: magnesj <1793152+magnesj@users.noreply.github.com>
Copilot AI changed the title [WIP] Disable default IO for proxy fields in AppFwk AppFwk: Disable XML IO for proxy fields by default Jan 18, 2026
Copilot AI requested a review from magnesj January 18, 2026 09:31
Copilot AI and others added 4 commits January 18, 2026 11:01
Enable IO for DemoPdmObject's proxy field since it's used by the
ChildArrayFieldSerializing test which expects serialization to work.
Simplify ProxyFieldIODisabled test to only use SimpleObj which has
the default proxy field IO behavior.
The CopyObject test uses copyObject which relies on XML serialization.
Enable IO and copyable for SimpleObj's proxy field to support this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AppFwk : Disable default IO for proxy fields

2 participants